RM-37764: Fix FP on long-form-functions-have-a-terminating-return-statement#115
Merged
reniers-tiobe merged 2 commits intomainfrom Jan 23, 2026
Merged
RM-37764: Fix FP on long-form-functions-have-a-terminating-return-statement#115reniers-tiobe merged 2 commits intomainfrom
long-form-functions-have-a-terminating-return-statement#115reniers-tiobe merged 2 commits intomainfrom
Conversation
zon-tiobe
approved these changes
Jan 23, 2026
Contributor
zon-tiobe
left a comment
zon-tiobe
left a comment
There was a problem hiding this comment.
LGTM! Seems to cover all the extra cases now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix FP on
long-form-functions-have-a-terminating-return-statementforif-elseif-elseconstruct.The
elseifnode was not explicitly handled. See RM-37764 for the AST. Theelseifnode is not ablock, but anelseifnode.