Potential bug fix for a corner case in find() and additional method#7
Open
aarpon wants to merge 2 commits intotinevez:masterfrom
Open
Potential bug fix for a corner case in find() and additional method#7aarpon wants to merge 2 commits intotinevez:masterfrom
aarpon wants to merge 2 commits intotinevez:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I have been using your great
@treeclass for a while and I recently committed a small fix and new commodity method. (Sorry that I put them in the same pull request). Please feel free to keep or reject as you wish.Bug fix in
@tree/findIf a tree contains empty values in the
Nodeproperty, the following will fail:find(myTree == value)since
val = [ obj.Node{:} ] ;in
@tree/findwill cause the empty values to be dropped. Thevalarray will be shorter than the originalobj.Nodearray and the subsequentI = find(val, varargin{:});call will return indices that are not pointing to the correct values in the tree.
Commodity method
@tree/findbranchpointsA while ago I added a
@tree/findbranchpointsmethod that comes in handy when you want to spot all branch points in the tree.