Skip to content

Comments

Clean up basePath/assetPrefix config#321

Open
isaaclombardssw wants to merge 2 commits intomainfrom
clean-up-basepath-config
Open

Clean up basePath/assetPrefix config#321
isaaclombardssw wants to merge 2 commits intomainfrom
clean-up-basepath-config

Conversation

@isaaclombardssw
Copy link
Collaborator

@isaaclombardssw isaaclombardssw commented Feb 13, 2026

Summary

  • Remove default empty string fallbacks for basePath and assetPrefix so they remain undefined when not set
  • Use ternary instead of && for the images path spread to avoid spreading falsy values

Test plan

  • Verify dev server works without NEXT_PUBLIC_BASE_PATH set
  • Verify build works with NEXT_PUBLIC_BASE_PATH set to a subpath

🤖 Generated with Claude Code

Remove unnecessary fallbacks (empty string, undefined) so basePath
is undefined when not set, and use explicit ternary for image path spread.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tina-docs Ready Ready Preview, Comment Feb 16, 2026 11:43pm

Request Review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant