added support of *.jar file extension in zip and unzip

[akhikhl]

It would be nice to use zip and unzip functions not only on ZIP-files, but also on JAR-files.

[timyates]

Sorry it took so long to get back to this, illness, Easter and a ton of stuff at work seem to have bogged me down for the past couple of weeks :sadpanda:

Wouldn't this require changing the underlying zip method to use JarOutputStream instead of ZipOutputStream? Maybe a separate jar/unjar method pair would be a better route?

[akhikhl]

Yeah, no problem :)

Let's analyze, what we have.
Jar(Input/Output)Stream classes differ from Zip versions only by special handling of manifest:

• JarOutputStream accepts manifest as a parameter to constructor
• JarInputStream has accessor getManifest

and that's it.

Since zip/unzip functions in groovy-common-extensions only talk on the level of File/Collection, manifests cannot be exposed with these functions. But I still think, that it is OK to treat JARs as ZIPs, i.e. to allow zip/unzip JAR files. Sometimes manifest does not need special treatment - it's another file being zipped/unzipped, not more. What do you think?

Separate jar/unjar methods is a good idea. But then File/Collection parameters/return results are not enough - we should give access to manifest. I'll think on possible function signatures.

[timyates]

Of course you're right 😊 (told you I'd been ill)

I'm actually wondering whether it's worth just removing the extension checking... So it will just try and treat the file as a zip no matter what it's extension is...