Skip to content

Conversation

@timoninmaxim
Copy link
Owner

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@timoninmaxim timoninmaxim force-pushed the IGNITE-23722__jdbc_client_info branch from 623f725 to 159efe5 Compare November 27, 2024 13:54
timoninmaxim and others added 25 commits November 27, 2024 17:28
…custom format - Fixes apache#11674.

Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com>
…or JOINs and other SQL nodes - Fixes apache#11663.

Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com>
…he#11691)

`sonar-pr-from-fork-build.yml` and `sonar-pr-from-fork-scan.yml`
analyze PRs. `sonar-pr-from-fork-scan.yml` needs privileges to
access the `SONARCLOUD_TOKEN` and to update the status of the PR
check.

To avoid a malicious PR from accessing those privileges, Ignite
requires approval for GitHub Actions, and reviews the PR to
catch any malicious code before approving the workflow.

These changes makes sure the privileged workflow is ran against
the commit that was approved, and does not pull in any changes
that may have been added to the PR after approval.
…ystem functions/operators - Fixes apache#11684.

Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com>
…#11707.

Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com>
…can - Fixes apache#11651.

Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com>
@timoninmaxim timoninmaxim force-pushed the IGNITE-23722__jdbc_client_info branch from ad8e43c to 12ddf01 Compare December 10, 2024 15:59
@timoninmaxim timoninmaxim force-pushed the IGNITE-23722__jdbc_client_info branch from 2053616 to cbe0870 Compare December 11, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.