Add refactoring #1
Conversation
| @guesses = [] | ||
| @number_correct = 0 | ||
| @current_card = 0 | ||
| @card_position = 0 |
There was a problem hiding this comment.
This naming better represents how this value is being used, which is as an index position.
| @deck.cards[@card_position] | ||
| end | ||
|
|
||
| def delay_output(seconds) |
There was a problem hiding this comment.
More dynamic, better named, and testable.
| end | ||
|
|
||
| def check_guess(guess) | ||
| @number_correct += 1 if guess.correct? |
There was a problem hiding this comment.
Less lines of code, testable, and more readable.
|
|
||
| def percent_correct | ||
| (@number_correct.to_f / deck.cards.length * 100).to_i | ||
| (@number_correct.to_f / deck.count * 100).to_i |
There was a problem hiding this comment.
Fixing indentation is part of refactoring/cleanup.
| end | ||
|
|
||
| def game | ||
| def start_game |
| puts "Question: #{card.question}" | ||
| input = gets.chomp | ||
| record_guess(input) | ||
| puts "This is card number #{@card_position + 1} out of #{deck.count}" |
There was a problem hiding this comment.
Indentation matters for readability.
| round = Round.new(deck) | ||
|
|
||
| assert_equal 1, round.delay_output(1) | ||
| assert_equal 2, round.delay_output(2) |
There was a problem hiding this comment.
We discovered quite a bit about the sleep method by writing these tests.
| assert_equal 2, round.delay_output(2) | ||
| end | ||
|
|
||
| def test_check_guess |
There was a problem hiding this comment.
Whenever there are multiple scenarios based on a condition, we want to test both of them.
| end | ||
|
|
||
| def input | ||
| # More on why I do this with the mocks and stubs lesson |
There was a problem hiding this comment.
We always want to isolate user input.
| def start | ||
| puts "Welcome! You're playing with #{deck.cards.count} cards" | ||
| sleep 1.5 | ||
| puts "Welcome! You're playing with #{deck.count} cards" |
There was a problem hiding this comment.
I built a count method on the deck class, I should use it.
No description provided.