Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Pedal Smoothness as a new selectable data source for the Powerbar extension (issue #75), including settings/UI support and the streaming/rendering logic.
Changes:
- Add new
SelectedSource.PEDAL_SMOOTHNESSand localized strings for the new source and its min/max range labels. - Persist new settings (
minPedalSmoothness/maxPedalSmoothness) and expose them in the settings screen when Pedal Smoothness is selected. - Implement Pedal Smoothness streaming in
Windowand refactor several enums intodatatypes/.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds EN strings for Pedal Smoothness source + min/max labels. |
| app/src/main/res/values-de/strings.xml | Adds DE strings for Pedal Smoothness source + min/max labels. |
| app/src/main/kotlin/de/timklge/karoopowerbar/screens/MainScreen.kt | Adds UI controls and persistence wiring for Pedal Smoothness min/max settings; switches to shared SelectedSource. |
| app/src/main/kotlin/de/timklge/karoopowerbar/datatypes/SelectedSource.kt | Moves SelectedSource out of the screen file and adds PEDAL_SMOOTHNESS. |
| app/src/main/kotlin/de/timklge/karoopowerbar/datatypes/PowerStreamSmoothing.kt | Extracts power smoothing enum from Window. |
| app/src/main/kotlin/de/timklge/karoopowerbar/datatypes/PedalBalanceSmoothing.kt | Extracts pedal-balance smoothing enum from Window. |
| app/src/main/kotlin/de/timklge/karoopowerbar/datatypes/Gears.kt | Extracts gears enum from Window. |
| app/src/main/kotlin/de/timklge/karoopowerbar/datatypes/FlightAttendantSuspensionStateValue.kt | Extracts flight attendant state enum from Window. |
| app/src/main/kotlin/de/timklge/karoopowerbar/datatypes/FlightAttendantSuspensionMode.kt | Extracts flight attendant mode enum from Window. |
| app/src/main/kotlin/de/timklge/karoopowerbar/datatypes/FlightAttendantSuspensionLocation.kt | Extracts flight attendant location enum from Window. |
| app/src/main/kotlin/de/timklge/karoopowerbar/Window.kt | Adds Pedal Smoothness streaming + rendering; updates imports after enum extraction. |
| app/src/main/kotlin/de/timklge/karoopowerbar/Settings.kt | Adds persisted min/max pedal smoothness settings fields and defaults; updates SelectedSource import. |
| app/src/main/kotlin/de/timklge/karoopowerbar/ForegroundService.kt | Updates SelectedSource import path. |
| app/src/main/kotlin/de/timklge/karoopowerbar/CustomProgressBar.kt | Updates SelectedSource import path. |
| app/build.gradle.kts | Updates generated manifest release notes for this release. |
| README.md | Documents Pedal Smoothness as a supported data source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #75