This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Draft
Conversation
f9ae54a to
60903ad
Compare
bdb3624 to
f293624
Compare
All matrix builds were using the same cache key, causing collisions. pgx puts the postgres data directory in `target/pgx-test-data-<pg_ver>`, which the `Swatinem/rust-cache` action cleans, by removing all its content, and subsequently caches. This breaks pgx tests, which do not expect the directory to be empty. The combination of the cache collisions and incorrect caching caused a number of build failures, which could only be fixed by removing the cached artifacts from the GitHub cache.
This commit adds support to build arm64 packages. The steps taken are somewhat convoluted. As GitHub doesn't offer hosted arm64 runners, we have a self-hosted runner. For security reasons, GitHub doesn't allow self-hosted runners to be used with public repositories. For that purpose, we have created the `promscale_extension_private` repository, which is a private clone of the `promscale_extension` repository. The `release` GitHub workflow is designed to be run in _both_ the public and private repository. In the public repository its behaviour is unchanged. In the private repository, it uses our self-hosted arm64 runners and attempts to attach the packages to the draft release which was created in the `promscale_extension` repository.
f293624 to
fe550b7
Compare
Member
Author
|
I have the following TODOs before this is going to work:
|
Member
Author
|
I opened this change as a PR to the |
Member
Author
|
It would also be nice to automate the tag push from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds support to build arm64 packages. The steps taken are
somewhat convoluted.
As GitHub doesn't offer hosted arm64 runners, we have a self-hosted
runner. For security reasons, GitHub doesn't allow self-hosted runners
to be used with public repositories. For that purpose, we have created
the
promscale_extension_privaterepository, which is a private cloneof the
promscale_extensionrepository.The
releaseGitHub workflow is designed to be run in both the publicand private repository. In the public repository its behaviour is
unchanged. In the private repository, it uses our self-hosted arm64
runners and attempts to attach the packages to the draft release which
was created in the
promscale_extensionrepository.Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: