This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Add safety check for label id existence to _prom_catalog.create_series#465
Draft
JamesGuthrie wants to merge 1 commit intomasterfrom
Draft
Add safety check for label id existence to _prom_catalog.create_series#465JamesGuthrie wants to merge 1 commit intomasterfrom
_prom_catalog.create_series#465JamesGuthrie wants to merge 1 commit intomasterfrom
Conversation
JamesGuthrie
force-pushed
the
jg/throw-if-labels-nonexistant
branch
2 times, most recently
from
0875545 to
bf0f914
Compare
JamesGuthrie
force-pushed
the
jg/throw-if-labels-nonexistant
branch
from
bf0f914 to
6b51423
Compare
It is possible that the Promscale connector could have an invalid cache from label to label_id. This check ensures that we catch being an invalid label_id being passed to `create_series`.
JamesGuthrie
force-pushed
the
jg/throw-if-labels-nonexistant
branch
from
6b51423 to
28f957c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It is possible that the Promscale connector could have an invalid cache
from label to label_id. This check ensures that we catch being an
invalid label_id being passed to
create_series.Merge requirements
Please take into account the following non-code changes that you may need to make with your PR:
Updated the relevant documentation