This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Switch to time-based epoch for series cache#1653
Draft
JamesGuthrie wants to merge 3 commits intomasterfrom
Draft
Switch to time-based epoch for series cache#1653JamesGuthrie wants to merge 3 commits intomasterfrom
JamesGuthrie wants to merge 3 commits intomasterfrom
Conversation
JamesGuthrie
force-pushed
the
jg/time-based-epoch
branch
3 times, most recently
from
510d0b7 to
aff9662
Compare
JamesGuthrie
changed the title
alejandrodnm
approved these changes
Sep 29, 2022
Contributor
alejandrodnm
left a comment
alejandrodnm
left a comment
There was a problem hiding this comment.
LGTM but I'd wait for someone else with more experience with this part of the code to review it before merging. This is the first time I look into this part of the code.
JamesGuthrie
force-pushed
the
jg/time-based-epoch
branch
from
aff9662 to
50a7061
Compare
This is a companion change to [1]. That change modifies the database schema to switch to a time-based epoch. This change propagates the time-based epoch into the Promscale connector. For more details about the rationale behind this change, see [1]. [1]: timescale/promscale_extension#512
JamesGuthrie
force-pushed
the
jg/time-based-epoch
branch
from
776022b to
c498b09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a companion change to 1. That change modifies the database
schema to switch to a time-based epoch. This change propagates the
time-based epoch into the Promscale connector.
For more details about the rationale behind this change, see 1.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR:
CHANGELOG entry for user-facing changesUpdated the relevant documentation