This repository was archived by the owner on Aug 4, 2021. It is now read-only.
Http Request Duration Histogram should be in seconds unit#106
Open
Zslow wants to merge 1 commit intotimescale:masterfrom
Open
Http Request Duration Histogram should be in seconds unit#106Zslow wants to merge 1 commit intotimescale:masterfrom
Zslow wants to merge 1 commit intotimescale:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 13.18% 13.18%
=======================================
Files 4 4
Lines 622 622
=======================================
Hits 82 82
Misses 525 525
Partials 15 15Continue to review full report at Codecov.
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I changed the units of the Http Request Duration Histogram to Seconds.
Here's a link to the official Prometheus documentation where states that base units should be used for any metric, as a best practice.
https://prometheus.io/docs/practices/naming/#metric-names
We are testing this adapter on a project and needed the metric with the right unit in order to know if http requests are being lost.
Thank You.