Removed contrib references. Still requires swank.

[p-b-west]

Hi Tim,

In case you're still interested, I have removed the contrib references from the code. The swank requirement is still there; I haven't tried to replace it with cider because all of that stuff is a mystery to me.

The project compiles. That's the only claim I will make for it.

As to the SLF4J stuff, is there some IDE logging interface that can be invoked? What about just substituting java.util.logging for those instances?

I haven't the faintest idea about making plugins for NB, hence the basic questions. If I can do something quite straughtforward, I'm happy to do it, but I am not looking to get involved in NetBeans plugins.

[timboudreau]

Did the tests pass for you?

[INFO] ------------------------------------------------------------------------
[INFO] Building org-enclojure-repl-client 1.6
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org-enclojure-repl-client ---
[INFO] Deleting /home/tim/work/personal/enclojure/org-enclojure-repl-client/target
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ org-enclojure-repl-client ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 61 resources
[INFO] Copying 51 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ org-enclojure-repl-client ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 7 source files to /home/tim/work/personal/enclojure/org-enclojure-repl-client/target/classes
[INFO] 
[INFO] --- clojure-maven-plugin:1.3.5:compile (compile-clojure) @ org-enclojure-repl-client ---
Compiling org.enclojure.ide.repl.DefReplWindowFactory to /home/tim/work/personal/enclojure/org-enclojure-repl-client/target/classes
Compiling org.enclojure.ide.repl.classpaths to /home/tim/work/personal/enclojure/org-enclojure-repl-client/target/classes
Compiling org.enclojure.ide.repl.repl-data to /home/tim/work/personal/enclojure/org-enclojure-repl-client/target/classes
Compiling org.enclojure.ide.repl.repl-history to /home/tim/work/personal/enclojure/org-enclojure-repl-client/target/classes
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Compiling org.enclojure.ide.repl.repl-history-browse to /home/tim/work/personal/enclojure/org-enclojure-repl-client/target/classes
Exception in thread "main" java.lang.Exception: Unable to resolve var: *print-circle* in this context (main.clj:114)
    at clojure.lang.Compiler.analyzeSeq(Compiler.java:5376)

[p-b-west]

Hi Tim,

My apologies. It looks as though I only built the Enclosure tools.

In order to build the lot, I had to remove references to print-circle and print-lines. I don't know what they were all about, but print-circle and print-lines were both marked "not yet supported" in the original contrib distribution. After commenting out the references to them, cleaning and rebuilding Enclojure plugin with dependencies, the build worked and the tests passed, except for a couple of modules for which no tests were executed.

I had to do one other thing. I'm on OS X 10.10.1, and I have the Apple JDK 1.6 and the Oracle 1.8 installed. I had to set
<netbeans.hint.jdkPlatform>JDK_1.8</netbeans.hint.jdkPlatform>
in nb-configuration.xml in order to have the required sun classes located.

I don't know how pull requests work. I assume I should close this request and create a new one. If I do that, should I revert nb-configuration.xml?

[timboudreau]

Don't worry about nb-configuration.xml - I should have probably put it in
.gitignore, but don't worry about it.

If you update your clone, the pull request should get updated automagically

• at least it does that when it's a dedicated branch, but I assume "master"
  isn't special. Try just doing some updates and see if it picks them up.

On Fri, Jan 16, 2015 at 8:34 AM, numinasthmatic notifications@github.com
wrote:

Hi Tim,

My apologies. It looks as though I only built the Enclosure tools.

In order to build the lot, I had to remove references to print-circle
and print-lines. I don't know what they were all about, but
print-circle and print-lines were both marked "not yet supported" in
the original contrib distribution. After commenting out the references to
them, cleaning and rebuilding Enclojure plugin with dependencies, the build
worked and the tests passed, except for a couple of modules for which no
tests were executed.

I had to do one other thing. I'm on OS X 10.10.1, and I have the Apple JDK
1.6 and the Oracle 1.8 installed. I had to set
JDK_1.8
in nb-configuration.xml in order to have the required sun classes located.

I don't know how pull requests work. I assume I should close this request
and create a new one. If I do that, should I revert nb-configuration.xml?

—
Reply to this email directly or view it on GitHub
#1 (comment).

http://timboudreau.com