Skip to content

Support pnpm v9#40

Merged
octogonz merged 1 commit intotiktok:mainfrom
gavinxgu:guxiang/pnpm-9
Jun 9, 2025
Merged

Support pnpm v9#40
octogonz merged 1 commit intotiktok:mainfrom
gavinxgu:guxiang/pnpm-9

Conversation

@gavinxgu
Copy link
Contributor

@gavinxgu gavinxgu commented Jun 8, 2025

#37

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gavinxgu
Copy link
Contributor Author

gavinxgu commented Jun 8, 2025

@octogonz I've added pnpm v9 support to pnpm-sync. Could you provide some guidance on how to write tests for this feature?

@octogonz
Copy link
Member

octogonz commented Jun 8, 2025

Awesome, thanks! 🥳

@octogonz
Copy link
Member

octogonz commented Jun 8, 2025 •
edited
Loading

Could you increase the version number for both pnpm-sync and pnpm-sync-lib to both be 0.3.0? We'll publish a release after the PR is merged.

(They should be lockstepped, because pnpm-sync has a fixed version dependency.)

@gavinxgu
Copy link
Contributor Author

gavinxgu commented Jun 9, 2025

Could you increase the version number for both pnpm-sync and pnpm-sync-lib to both be 0.3.0? We'll publish a release after the PR is merged.

(They should be lockstepped, because pnpm-sync has a fixed version dependency.)

pnpm-sync-lib is now at version 0.3.0, and pnpm-sync is at 0.2.9. If I use version 0.3.0 of pnpm-sync-lib, it will conflict with the remote version on npm. Should I upgrade to version 0.3.1 or 0.4.0 instead?

@octogonz
Copy link
Member

octogonz commented Jun 9, 2025

0.3.1 looks good 👍

@octogonz octogonz merged commit e81dbdf into tiktok:main Jun 9, 2025
2 checks passed
@octogonz
Copy link
Member

octogonz commented Jun 9, 2025

The packages have been published 🚀

gavinxgu added a commit to gavinxgu/rushstack that referenced this pull request Jun 9, 2025
@gavinxgu
fix: upgrade pnpm-sync-lib to 3.0.1 to support pnpm v9
49e2ca7 
tiktok/pnpm-sync#40
gavinxgu added a commit to gavinxgu/rushstack that referenced this pull request Jun 9, 2025
@gavinxgu
[rush] Upgrade pnpm-sync-lib to v3.0.1 for pnpm v9 compatibility
7120a1f 
tiktok/pnpm-sync#40
@gavinxgu gavinxgu mentioned this pull request Jun 9, 2025
Closed
gavinxgu added a commit to gavinxgu/rushstack that referenced this pull request Jun 9, 2025
@gavinxgu
[rush] Upgrade pnpm-sync-lib to v0.3.1 for pnpm v9 compatibility
bb2695e 
tiktok/pnpm-sync#40
@gavinxgu gavinxgu mentioned this pull request Jun 9, 2025
Merged
@octogonz
Copy link
Member

octogonz commented Jun 9, 2025

BTW I will have to think about a good way to do automated testing for this project. Maybe we can look at how PNPM does it.

@gavinxgu
Copy link
Contributor Author

gavinxgu commented Jun 9, 2025

How about we first merge #41 to ensure the current logic is correct, and then we can provide more comprehensive tests.

@octogonz octogonz mentioned this pull request Jun 10, 2025
Closed
gavinxgu added a commit to gavinxgu/rushstack that referenced this pull request Jun 11, 2025
@gavinxgu
[rush] Upgrade pnpm-sync-lib to v0.3.3 for pnpm v9 & v10 compatibility
01477da 
tiktok/pnpm-sync#40
tiktok/pnpm-sync#43
gavinxgu added a commit to gavinxgu/rushstack that referenced this pull request Jun 13, 2025
@gavinxgu
[rush] Upgrade pnpm-sync-lib to v0.3.3 for pnpm v10 compatibility
b31e5f2 
tiktok/pnpm-sync#40
tiktok/pnpm-sync#43
@gavinxgu gavinxgu mentioned this pull request Jun 13, 2025
Merged
gavinxgu added a commit to gavinxgu/rushstack that referenced this pull request Jun 13, 2025
@gavinxgu
[rush] Upgrade pnpm-sync-lib to v0.3.3 for pnpm v10 compatibility
2985261 
tiktok/pnpm-sync#40
tiktok/pnpm-sync#43
gavinxgu added a commit to gavinxgu/rushstack that referenced this pull request Jun 20, 2025
@gavinxgu
[rush] Upgrade pnpm-sync-lib to v0.3.3 for pnpm v10 compatibility
eb2c2ca 
tiktok/pnpm-sync#40
tiktok/pnpm-sync#43
gavinxgu added a commit to gavinxgu/rushstack that referenced this pull request Jun 20, 2025
@gavinxgu
[rush] Upgrade pnpm-sync-lib to v0.3.3 for pnpm v10 compatibility
e13d10a 
tiktok/pnpm-sync#40
tiktok/pnpm-sync#43
gavinxgu added a commit to gavinxgu/rushstack that referenced this pull request Jun 20, 2025
@gavinxgu
[rush] Upgrade pnpm-sync-lib to v0.3.3 for pnpm v10 compatibility
8790575 
tiktok/pnpm-sync#40
tiktok/pnpm-sync#43
gavinxgu added a commit to gavinxgu/rushstack that referenced this pull request Jun 20, 2025
@gavinxgu
[rush] Upgrade pnpm-sync-lib to v0.3.3 for pnpm v10 compatibility
8055d31 
tiktok/pnpm-sync#40
tiktok/pnpm-sync#43
iclanton added a commit to microsoft/rushstack that referenced this pull request Dec 23, 2025
@gavinxgu @octogonz @iclanton
[rush] Upgrade pnpm-sync-lib to v0.3.3 for pnpm v10 compatibility (#…
4977b5b 
…5254)

* [rush] Upgrade `pnpm-sync-lib` to v0.3.3 for pnpm v10 compatibility

tiktok/pnpm-sync#40
tiktok/pnpm-sync#43

* Fix merge conflicts so "rush-lib" compiles again

* Revert Lockfile Explorer changes, since PNPM 10 support was already implemented after this PR was started

* Dynamic import `@rushstack/rush-pnpm-kit-*` packages.

* Include explicit types.

* Include missing eslint config, README, and LICENSE files.

* Fix lint issues.

* fixup! Dynamic import `@rushstack/rush-pnpm-kit-*` packages.

* Dynamically import the pnpm kits in PnpmShrinkwrapFile.

* Revert "Dynamically import the pnpm kits in PnpmShrinkwrapFile."

This reverts commit 6ede3d3.

* Lazy-load the pnpm kits in PnpmShrinkwrapFile.

* Leave a note about reworking load of @rushstack/rush-pnpm-kit-*.

---------

Co-authored-by: Pete Gonzalez <4673363+octogonz@users.noreply.github.com>
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@octogonz octogonz octogonz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gavinxgu @CLAassistant @octogonz