Skip to content

Build NumPy and SciPy against AOCL#231

Open
AlexKurek wants to merge 22 commits intotikk3r:fedora-py3from
AlexKurek:numpy-and-scipy-against-aocl
Open

Build NumPy and SciPy against AOCL#231
AlexKurek wants to merge 22 commits intotikk3r:fedora-py3from
AlexKurek:numpy-and-scipy-against-aocl

Conversation

@AlexKurek
Copy link
Contributor

@AlexKurek AlexKurek commented Jan 23, 2025

Description

Try to do the same: #229 here.
Note that numpy and scipy are removed from requirements.txt, so this should me merged at the same time: #222.

@AlexKurek AlexKurek marked this pull request as draft January 23, 2025 08:57
@AlexKurek
Copy link
Contributor Author

AlexKurek commented Jan 23, 2025

Currently:

Preparing metadata (pyproject.toml): finished with status 'error'

and:

../numpy/core/src/common/npy_cpu_dispatch.h:36:14: fatal error: npy_cpu_dispatch_config.h: No such file or directory
36 | #include "npy_cpu_dispatch_config.h"

It seems it was a distutils related file located in numpy/distutils/include/npy_cpu_dispatch_config.h.
Disabling the dispacher (34fc9fe) does not help.

Important:

Run-time dependency scipy-openblas found: NO (tried pkgconfig)
Run-time dependency aocl-blas found: YES
Message: BLAS symbol suffix:
Run-time dependency aocl-lapack found: YES
[...]
User defined options
[...]
blas-order : AOCL-BLAS,openblas
lapack-order: AOCL-LAPACK,openblas

But there are a lot of AVX512 etc. occurrences. Seems worth doing.

@AlexKurek
Copy link
Contributor Author

Both numpy and scipy do build now.

@AlexKurek AlexKurek marked this pull request as ready for review January 26, 2025 07:27
@AlexKurek
Copy link
Contributor Author

Only test fails after removing numpy and scipy from requirements.txt. The container is built fine.

@tikk3r
Copy link
Owner

tikk3r commented Jan 26, 2025

Thanks, nice to be able to build them with vendor libraries. The tests will have to succeed before it can be merged.

It would also be nice to include some results to see if it gives any performance benefit or how much.

@AlexKurek
Copy link
Contributor Author

The tests will have to succeed before it can be merged.

I dont understand how it could be failing since numpy is installed in the test (https://github.com/tikk3r/flocs/blob/fedora-py3/.github/workflows/integration-tests.yml#L31C38-L31C48).
One way to fix the tests is to bring back numpy and scipy in requirements.txt.

@AlexKurek AlexKurek force-pushed the numpy-and-scipy-against-aocl branch 2 times, most recently from e13acc8 to ca9fe9c Compare January 26, 2025 15:13
@AlexKurek
Copy link
Contributor Author

Test is OK now both here and in MKL version.

@AlexKurek AlexKurek force-pushed the numpy-and-scipy-against-aocl branch from d265880 to 862247c Compare January 27, 2025 04:51
@AlexKurek AlexKurek closed this Jan 27, 2025
@AlexKurek AlexKurek reopened this Jan 29, 2025
@AlexKurek AlexKurek force-pushed the numpy-and-scipy-against-aocl branch 4 times, most recently from 1463680 to e3a2a60 Compare January 30, 2025 16:11
@AlexKurek AlexKurek force-pushed the numpy-and-scipy-against-aocl branch from 3b681f3 to 27dba60 Compare February 2, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Numpy and Scipy against vendor math libraries (AOCL/MKL)

2 participants