Skip to content

fix: when sending snapshot, snapshot.Next iterates forever until raft error #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maslino wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −6
Open

fix: when sending snapshot, snapshot.Next iterates forever until raft error #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions transport_replicate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,24 +151,27 @@ func (t *replicateTransport) sendSnapshot(m *proto.Message, rs *snapshotStatus)

default:
data, err = m.Snapshot.Next()

// to prevent err from being overrided
var innerError error
if len(data) > 0 {
// write block size
binary.BigEndian.PutUint32(sizeBuf, uint32(len(data)))
if _, err = bufWr.Write(sizeBuf); err == nil {
_, err = bufWr.Write(data)
if _, innerError = bufWr.Write(sizeBuf); innerError == nil {
_, innerError = bufWr.Write(data)
}
}

if err == nil {
err = innerError
}
}
}

// write end flag and flush
if err != nil && err != io.EOF {
return
}
binary.BigEndian.PutUint32(sizeBuf, 0)
if _, err = bufWr.Write(sizeBuf); err != nil {
return
}
if err = bufWr.Flush(); err != nil {
return
}
Expand Down