Skip to content

fix overflow bug #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fanzhoulll wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix overflow bug #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Dataxfer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const int kBytes_to_Bits = 8;
void data_sendtcp(thread_Settings * mSettings, char * mBuf, Timestamp mEndTime)
{
Timestamp lastPacketTime;
long currLen = 0;
unsigned long currLen = 0;
struct itimerval it;
max_size_t totLen = 0;

Expand All @@ -75,7 +75,6 @@ void data_sendtcp(thread_Settings * mSettings, char * mBuf, Timestamp mEndTime)

// Indicates if the stream is readable
bool canRead = true, mMode_Time = isModeTime( mSettings );

ReportStruct *reportstruct = NULL;

// InitReport handles Barrier for multiple Streams
Expand Down Expand Up @@ -119,7 +118,12 @@ void data_sendtcp(thread_Settings * mSettings, char * mBuf, Timestamp mEndTime)
}

if ( !mMode_Time ) {
mSettings->mAmount -= currLen;
if (mSettings->mAmount >= currLen) {
mSettings->mAmount -= currLen;
Copy link

@hselasky hselasky Oct 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indention style here.

Also, mAmount should only be compared for zero, because it is unsigned!

0 >= mSettings->mAmount

Should probably be:

0 == mSettings->mAmount

} else {
mSettings->mAmount = 0;
}

}

} while ( ! (sInterupted ||
Expand Down