feat(ot128): support for retro multi-reflection filtering setting#377
Draft
feat(ot128): support for retro multi-reflection filtering setting#377
Conversation
- Introduced a new function `supports_retro_multi_reflection_filtering` to check if the sensor model supports retro multi-reflection filtering. - Updated `HesaiSensorConfiguration` to include an optional `retro_multi_reflection_filtering` parameter. - Implemented methods in `HesaiHwInterface` for setting and getting the retro multi-reflection filtering state. - Modified configuration files and schemas to accommodate the new filtering option. - Enhanced logging to reflect changes in retro multi-reflection filtering settings during configuration checks.
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
…ub.com:tier4/nebula into feature/qt128-retro-multi-reflection-filtering
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
…s://github.com/tier4/nebula into feature/qt128-retro-multi-reflection-filtering
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 34.36% 34.31% -0.06%
==========================================
Files 130 130
Lines 10519 10545 +26
Branches 5708 5729 +21
==========================================
+ Hits 3615 3618 +3
- Misses 6188 6235 +47
+ Partials 716 692 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mojomex
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
Add a parameter
retro_multi_reflection_filtering: boolfor Hesai QT128 and OT128 that toggles the corresponding sensor setting.The setting suppresses ghost outputs at twice the distance of any retro-reflector in the scene.
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks