Skip to content

Change GitHub + Anaconda orgs#39

Merged
pdiakumis merged 3 commits intodevfrom
tlc
Mar 24, 2026
Merged

Change GitHub + Anaconda orgs#39
pdiakumis merged 3 commits intodevfrom
tlc

Conversation

@pdiakumis
Copy link
Copy Markdown
Collaborator

Moving to tidywf.

@pdiakumis pdiakumis requested a review from a team March 24, 2026 06:19
@pdiakumis pdiakumis self-assigned this Mar 24, 2026
@pdiakumis
Copy link
Copy Markdown
Collaborator Author

@claude what do you think about these changes?

@claude
Copy link
Copy Markdown

claude bot commented Mar 24, 2026

Claude finished @pdiakumis's task in 1m 3s —— View job


Review of PR #39: Change GitHub + Anaconda orgs

  • Gather context and review changes
  • Provide feedback

The changes are a straightforward umccrtidywf org rename across documentation, config, and source files. The intent is clear and the approach is correct. However, there are a few issues worth flagging.

Bug: Missed umccr references in deploy.yaml

Three lines in .github/workflows/deploy.yaml still reference umccr and were not updated. These will cause the CI deployment to upload to the wrong Anaconda org and resolve channels from the old org:

Line 42 — build channel:

rattler-build build \
  --channel umccr \   # ← should be tidywf

Line 52 — upload owner:

rattler-build upload anaconda \
  --owner umccr \   # ← should be tidywf

Lines 58–59 — lock channel args:

CHANNEL_ARGS="--channel umccr --channel conda-forge"
[[ ... ]] && CHANNEL_ARGS="--channel umccr/label/dev ${CHANNEL_ARGS}"
# ↑ both umccr references should be tidywf

The --owner flag on the upload step is the most critical — it controls where the package is published to Anaconda.

Fix this →

Positive: deploy.yaml variable syntax improvement

The PR also switches from bash-style ${VAR} to GitHub Actions expression syntax ${{ env.VAR }} for workflow env vars — a good style improvement for clarity and consistency, even if both forms work in this context.

Everything else looks good

All other files (DESCRIPTION, README.qmd, conda recipes, env YAMLs, docs, vignettes, R/utils.R) have been correctly updated. The changes are mechanical and consistent.


Summary: LGTM with one fix needed — the three missed umccr references in deploy.yaml (lines 42, 52, 58–59) must be updated to tidywf before merging, otherwise CI will fail to upload the conda package to the correct org.

@pdiakumis pdiakumis merged commit 83b3829 into dev Mar 24, 2026
1 check passed
@pdiakumis pdiakumis deleted the tlc branch March 24, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant