You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The changes are a straightforward umccr → tidywf org rename across documentation, config, and source files. The intent is clear and the approach is correct. However, there are a few issues worth flagging.
Bug: Missed umccr references in deploy.yaml
Three lines in .github/workflows/deploy.yaml still reference umccr and were not updated. These will cause the CI deployment to upload to the wrong Anaconda org and resolve channels from the old org:
Line 42 — build channel:
rattler-build build \--channel umccr \ # ← should be tidywf
Line 52 — upload owner:
rattler-build upload anaconda \--owner umccr \ # ← should be tidywf
Lines 58–59 — lock channel args:
CHANNEL_ARGS="--channel umccr --channel conda-forge"[[ ... ]] && CHANNEL_ARGS="--channel umccr/label/dev ${CHANNEL_ARGS}"# ↑ both umccr references should be tidywf
The --owner flag on the upload step is the most critical — it controls where the package is published to Anaconda.
The PR also switches from bash-style ${VAR} to GitHub Actions expression syntax ${{ env.VAR }} for workflow env vars — a good style improvement for clarity and consistency, even if both forms work in this context.
Everything else looks good
All other files (DESCRIPTION, README.qmd, conda recipes, env YAMLs, docs, vignettes, R/utils.R) have been correctly updated. The changes are mechanical and consistent.
Summary: LGTM with one fix needed — the three missed umccr references in deploy.yaml (lines 42, 52, 58–59) must be updated to tidywf before merging, otherwise CI will fail to upload the conda package to the correct org.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving to tidywf.