Density-based Clustering (DBSCAN) and Model-based Clustering (GMMs)#209
Density-based Clustering (DBSCAN) and Model-based Clustering (GMMs)#209brendad8 wants to merge 45 commits intotidymodels:mainfrom
Conversation
also adjusted extract_cluster_summary to return NA vals for selected metrics for outlier cluster
|
Hello @brendad8 👋 This is a big amount of effort you have put into this, thank you! Before I give a more thorough review, could you move the code away from {Rfast} to {philentropy} like it is being done in: https://github.com/tidymodels/tidyclust/pull/199/files |
|
Hello Emil. Just took care of this in the last few commits. Let me know if you need anything from me or have any questions |
|
@EmilHvitfeldt - just a heads up, we have two more big PRs headed our way. I'm putting together some documentation about what was added and what are the bigger changes we might need to discuss, I share that as an Issue on here soon! :) |
|
Thanks for the heads up! I'm gonna try to review what I have Friday, if not then certainly Monday/Tuesday |
EmilHvitfeldt
left a comment
EmilHvitfeldt
left a comment
There was a problem hiding this comment.
overall looking good.
In addition to the requested changes, we need to make sure the GHAs run clean, one thing we need is for you to add the newly added models to _pkgdown.yml
|
please also add NEWS bullets in accordance to https://style.tidyverse.org/news.html |
…oving forcats use in tests
…ted dbscan::frNN()
|
@EmilHvitfeldt , so you have any insight into why the ubuntu builds are failing? Or anything we can do to get this merge-ready? Thank you! |
|
Sorry about the wait @kbodwin I will be starting tidyclust work next week! promise! |
3 participants
Closes #5
@kbodwin
Note: unstated dependency dbscan:::predict_frNN()
- This function is found in db_clust.R and predict_helpers.R