Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: important
Title: Supervised Feature Selection
Version: 0.2.0.9000
Version: 0.2.1
Authors@R: c(
person("Max", "Kuhn", , "max@posit.co", role = c("aut", "cre"),
comment = c(ORCID = "0000-0003-2402-136X")),
Expand Down Expand Up @@ -54,4 +54,4 @@ Config/usethis/last-upkeep: 2025-06-09
Encoding: UTF-8
Language: en-US
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.2
RoxygenNote: 7.3.3
6 changes: 3 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# important (development version)
# important 0.2.1

Required changes for new ggplot2 release.

# important 0.2.0

Expand All @@ -13,5 +15,3 @@ See their individual help pages for more information.
# important 0.0.1

* Initial CRAN submission.


3 changes: 2 additions & 1 deletion inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ CMD
Codecov
ORCID
PBC
ROR
Suich
desirabilities
doi
filtro
funder
ggplot
importances
mirai
pre
tibble
tidymodels
wc
2 changes: 1 addition & 1 deletion man/important-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 10 additions & 20 deletions tests/testthat/test-plots.R
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,9 @@ test_that("autoplot - classification", {
p1 <- autoplot(res_orig)
expect_s3_class(p1, "ggplot")
expect_equal(
p1$labels,
list(
y = NULL,
x = "Permutation Importance Score",
xintercept = "xintercept"
)
ggplot2::get_labs(p1),
list(x.sec = NULL, x = "Permutation Importance Score", y = NULL,
y.sec = NULL, xintercept = "xintercept", alt = "")
)
expect_equal(names(p1$mapping), "y")
expect_equal(
Expand All @@ -60,14 +57,10 @@ test_that("autoplot - classification", {
3L
)
expect_equal(
p2$labels,
list(
y = NULL,
x = "Permutation Importance Score",
xintercept = "xintercept",
xmin = "mean - std_errs * std_err",
xmax = "mean + std_errs * std_err"
)
ggplot2::get_labs(p2),
list(x.sec = NULL, x = "Permutation Importance Score", y = NULL,
y.sec = NULL, xintercept = "xintercept", xmin = "mean - std_errs * std_err",
xmax = "mean + std_errs * std_err", alt = "")
)

expect_equal(length(p2$layers), 3)
Expand Down Expand Up @@ -112,12 +105,9 @@ test_that("autoplot - classification", {
p3 <- autoplot(res_derv, metric = "brier_class")
expect_s3_class(p3, "ggplot")
expect_equal(
p3$labels,
list(
y = NULL,
x = "Permutation Importance Score",
xintercept = "xintercept"
)
ggplot2::get_labs(p3),
list(x.sec = NULL, x = "Permutation Importance Score", y = NULL,
y.sec = NULL, xintercept = "xintercept", alt = "")
)
expect_equal(length(p3$layers), 2)
expect_equal(names(p3$mapping), "y")
Expand Down