Conversation
variables so global defaults can be set in my.cnf or per-session without repeating options in every create table. table-level options override the default. converted all ha_toption_number and ha_toption_enum entries to ha_toption_sysvar. new default sysvars added for sync_mode, sync_interval_us, bloom_fpr, klog_value_threshold, l0_queue_stall_threshold, l1_file_count_trigger, level_size_ratio, min_levels, dividing_level_offset, skip_list_max_level, skip_list_probability, index_sample_ratio, block_index_prefix_len, min_disk_space, and isolation_level. fixed max_memory_usage sysvar description from 80% to 50% of system ram to match the actual library default (minimum 5% floor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all table options now have corresponding tidesdb_default_* session
variables so global defaults can be set in my.cnf or per-session
without repeating options in every create table. table-level options
override the default. converted all ha_toption_number and
ha_toption_enum entries to ha_toption_sysvar.
new default sysvars added for sync_mode, sync_interval_us, bloom_fpr,
klog_value_threshold, l0_queue_stall_threshold, l1_file_count_trigger,
level_size_ratio, min_levels, dividing_level_offset, skip_list_max_level,
skip_list_probability, index_sample_ratio, block_index_prefix_len,
min_disk_space, and isolation_level.
fixed max_memory_usage sysvar description from 80% to 50% of system
ram to match the actual library default (minimum 5% floor).