Conversation
…s and UX * remove query_cache_type/query_cache_size from generated my.cnf (removed in MariaDB 12.x, causes startup failure on default target) * use platform-correct plugin extension (.so/.dll) in plugin_load_add * move VCPKG_ROOT detection to top-level init so --skip-deps on Windows no longer crashes with unbound variable under set -u * fix PGO on macOS - use Clang-compatible -fprofile-instr-generate/use instead of GCC-only -fprofile-generate/use; merge .profraw via llvm-profdata in the training phase * add missing Windows case blocks in PGO instrument/optimize phases * replace hardcoded sudo with _needs_sudo() helper that checks prefix writability — avoids root-owned files in user-writable prefixes * remove dead -DTIDESDB_ROOT cmake cache variable (only the exported ENV is read by FIND_LIBRARY HINTS); set CMAKE_PREFIX_PATH once per OS in dedicated case blocks to prevent double-set on Windows * add --force to git submodule update for robustness on dirty checkouts * pass -DTIDESDB_BUILD_TESTS=OFF -DBUILD_SHARED_LIBS=ON when building the TidesDB library to skip unnecessary test/benchmark compilation * replace hardcoded-width box drawing (_cfg_row, row) with reusable draw_box() that auto-sizes borders to the widest visible content line, fixing misaligned boxes when paths exceed the old 66-char inner width
…ix connect user * pass --defaults-file pointing to the generated my.cnf in all mariadb-install-db invocations so it does not pick up system or default configs that reference missing plugins (e.g. provider_lzo on MariaDB 12.x), which caused data directory initialization to fail silently * write user= directive in my.cnf matching the actual runtime user (mysql for system installs, current user for user-local installs) * fix print_summary to show the correct connect user for user-local installs (system username instead of root)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corrections(install) - harden installer for cross-platform correctness and UX
(removed in MariaDB 12.x, causes startup failure on default target)
no longer crashes with unbound variable under set -u
instead of GCC-only -fprofile-generate/use; merge .profraw via
llvm-profdata in the training phase
writability — avoids root-owned files in user-writable prefixes
ENV is read by FIND_LIBRARY HINTS); set CMAKE_PREFIX_PATH once per OS
in dedicated case blocks to prevent double-set on Windows
the TidesDB library to skip unnecessary test/benchmark compilation
draw_box() that auto-sizes borders to the widest visible content line,
fixing misaligned boxes when paths exceed the old 66-char inner width