Closed
Conversation
Add Go bindings for the new TidesDB v8.7.0 purge API methods: purge database and purge column family. Fixes tidesdb#49
Member
|
@itniuma2026 review the DCO. Thank you for PR |
Member
|
@itniuma2026 close but you need to review the C documentation. Look at the method names and parameters and line them up properly with tests to prove you've done it well. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Go bindings for the new TidesDB v8.7.0 purge API methods: purge database and purge column family.
Approach
Add two new methods to the TidesDB Go binding: (1)
Purge()which calls the C functiontidesdb_purge_dbto purge all in-memory queues and buffers for the entire database, and (2)PurgeColumnFamily(name string)which callstidesdb_purge_column_familyto purge in-memory queues and buffers for a specific column family. Both methods should follow the existing pattern in tidesdb.go of calling the underlying C API via cgo, checking the returned error, and wrapping it in a Go error. Tests should be added in tidesdb_test.go to verify both purge methods work correctly.Files Changed
tidesdb.gotidesdb_test.goRelated Issue
Fixes #49
Testing
No tests were added with this change. Happy to add them if needed.