Skip to content

Conversation

@NucleaPeon
Copy link

  • Ignore .DS_Store folder setting files, src/qmake when building in tree
  • added name to about contributors

…Macs

  - Ignore .DS_Store folder setting files, src/qmake when building in tree
  - added name to about contributors

Signed-off-by: Daniel Kettle <danielk@bigleaf.net>
@tibirna
Copy link
Owner

tibirna commented Mar 23, 2020

What is the license on the cocoainitializer.{h,mm} files? Headers indicate authors other than you.

@NucleaPeon
Copy link
Author

NucleaPeon commented Mar 23, 2020

Sharp eye.
I pulled the code from https://github.com/torrent-file-editor/torrent-file-editor.
License file reports GPL 3.0 https://github.com/torrent-file-editor/torrent-file-editor/blob/master/LICENSE

Edit (clarification)

I didn't write it, I left in the previous authors.
I attempted to find a fix for the same issue on a project I'm working on.
In an obscure mailing list, I found a reference to CocoaInitializer. Searching for it, I found a github result that had those two files in it. I'm not sure if the repo owners wrote it themselves, but information was sparse and it fixed my issue.

The QT developers dismissed the NS pool memory autorelease issue, saying 5.3.1/2 was no longer going to be supported for snow leopard going forward and I haven't seen the issue on much later versions of OS X (10.11)

@filiperinaldi
Copy link
Contributor

I haven't seen the issue on much later versions of OS X

I suppose this PR is no longer relevant then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants