Improve the required bytes calculation. #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lestcape
force-pushed
the
CutString
branch
2 times, most recently
from
cf33cba to
14ac67a
Compare
…to their character encoding
…eLabels label, to the buffer
… internal encoding as the source for the encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improve the calculation of the required bytes of an string that should be stored using a user custom charset.
The idea is delegate the cut to the buffer that is who really know the final charset of the string in the stream (the sav file). At same time this cut the string using the bytes representation instead of the character length representation of the charset. See
mb_strcutfor more details.