Skip to content

Reminders#414

Open
valeriagrazzini wants to merge 8 commits intomainfrom
reminders
Open

Reminders#414
valeriagrazzini wants to merge 8 commits intomainfrom
reminders

Conversation

@valeriagrazzini
Copy link
Copy Markdown
Collaborator

created 3 types of cases:

  • Account created but no Tokens or Collectibles (Email with tips on how to deploy assets)
  • Account and tokens / collectibles created but no pools to start using features (Email with tips on how to config pool)
  • Pool created for tokens / collectibles but no withdrawals for that pool (Email with tips on how to config rewards etc)

the email template has been created, only the final title/text need to be implemented.

let title: string, message: string;
const accounts = await AccountProxy.getActiveAccountsEmail();

// REMINDERS BASED ON THE ACCOUNT
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valeriagrazzini Hey! Please use normal casing for comments or remove your notes when publishing the PR :)

@peterpolman
Copy link
Copy Markdown
Member

@valeriagrazzini We need to keep track of who we have mailed somehow. I'll add a task for that to refine.

Perhaps we already noticed this during refinement, but currently we will be spamming people every week with the same email when they meet the email conditions.

@peterpolman
Copy link
Copy Markdown
Member

  • Add new collection "TransactionalEmails"
  • Add new schema TransactionalEmail
TransactionalEmail {
  type: string, // 'account_no_erc20_no_erc721'
  sub: string, // '123455'
}
  • Move 3 email conditions into separate agenda jobs
  • Make sure to choose good job name constants
  • Before sending the email check how many TransactionalEmail objects exist for the job specific sub and TransactionalEmail.type
  • After sending the email create the TransactionalEmail
  • Use the job name constant for TransactionalEmail.type

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bram-rongen
Copy link
Copy Markdown
Collaborator

I'd suggest to consider using (external) email lifecycle tools. They can also deal with unsubscribing etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants