Open
Conversation
peterpolman
reviewed
Oct 2, 2022
src/jobs/remindersJob.ts
Outdated
| let title: string, message: string; | ||
| const accounts = await AccountProxy.getActiveAccountsEmail(); | ||
|
|
||
| // REMINDERS BASED ON THE ACCOUNT |
Member
There was a problem hiding this comment.
@valeriagrazzini Hey! Please use normal casing for comments or remove your notes when publishing the PR :)
Member
|
@valeriagrazzini We need to keep track of who we have mailed somehow. I'll add a task for that to refine. Perhaps we already noticed this during refinement, but currently we will be spamming people every week with the same email when they meet the email conditions. |
Member
|
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
I'd suggest to consider using (external) email lifecycle tools. They can also deal with unsubscribing etc.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








created 3 types of cases:
the email template has been created, only the final title/text need to be implemented.