remove 'outputs' from 'finish' calls#244
Open
valentin-grisel wants to merge 1 commit intothunderbird:mainfrom
Open
remove 'outputs' from 'finish' calls#244valentin-grisel wants to merge 1 commit intothunderbird:mainfrom
valentin-grisel wants to merge 1 commit intothunderbird:mainfrom
Conversation
ryanjjung
requested changes
Feb 17, 2026
| self.resources = resources | ||
| if len(outputs) > 0: | ||
| pulumi.warn(FINISH_OUTPUTS_DEPRECATION_MESSAGE) | ||
| self.register_outputs(outputs) |
Collaborator
There was a problem hiding this comment.
The documentation still indicates that calling register_outputs is necessary because it "signals to the Pulumi engine that the component resource has finished registering all its child resources and should be considered complete," even if we are not using it for actual outputs. I think this call still needs to happen, but with no outputs in the parameters.
Collaborator
|
This thread is pretty enlightening. The Pulumi devs seem to not really understand why this should be called, at least to some extent. Sounds like maybe some tech debt. No biggie. The consensus there is that there is some minimum convenience created by making the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Removed 'outputs' from 'finish' calls.
Benefits
Ready for next version.
Applicable Issues
pulumi/pulumi#242