Additional bloc architecture improvements#2064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR is a continuation of previous work to help improve the overall bloc architecture. The main changes include:
ProfileBlochas been split up intoSessionBlocandProfileBloc.SessionBlochandles initializing, adding, removing, and switching between accounts whileProfileBlocis used to handle the account's data (e.g., user information, subscriptions, favourites, etc.).UserSettingsBlocintoAccountSettingsCubit,UserBlocksCubitandUserMediaCubitto improve separation of concerns, and re-worked the settings pages to use the new blocs.I've also included an experimental refactor of the image viewer which doesn't rely on extended_image (the eventual goal is to remove extended_image as a dependency). This is enabled when experimental settings are enabled. Additionally, I've removed the tests temporarily as I want to completely re-do the test suite to better catch regressions in the future.
There will likely be follow up PRs to further clean up the codebase but this has gotten pretty large already 😅
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?