Refactor Tkinter UI for better maintainability and bug fixes#33
Refactor Tkinter UI for better maintainability and bug fixes#33google-labs-jules[bot] wants to merge 1 commit intomasterfrom
Conversation
- Created `simpletextgenerator/ui/base.py` with `BaseWindow` and `JobConfigForm` to reduce code duplication and enforce consistency. - Refactored `menu.py` to be the main application controller and properly manage child windows using `Toplevel`. - Refactored `new_job.py`, `edit_job.py`, `archive_delete.py`, `generating_only_job.py`, and `training.py` to inherit from `BaseWindow` and use shared components. - Fixed a bug in `edit_job.py` where `initial_model_to_load` was lost during editing. - Fixed a bug in `edit_job.py` where `destroy_window` was called immediately. - Updated `tests/ui/test_training.py` to mock `tkinter` correctly for headless testing.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Refactored the Python Tkinter UI to improve code quality, reduce duplication, and fix bugs.
Key changes:
BaseWindowandJobConfigForminsimpletextgenerator/ui/base.py.BaseWindowand useJobConfigFormfor configuration fields.menu.pyto cleaner structure.edit_job.pywhereinitial_model_to_loadwas not preserved.destroy_windowinedit_job.py.PR created automatically by Jules for task 11010792760452179861 started by @thtroyer