[WIP] fix: add overlay base-root and state-root consistency check #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
gab8i
force-pushed
the
gm_ensure_session_validity
branch
from
ce57dba to
f4eb962
Compare
gab8i
force-pushed
the
gm_overlay_deletions_fix
branch
from
9151587 to
c8b3c95
Compare
added 2 commits
December 4, 2025 17:37
When beginning a session, ensure that the oldest overlay’s previous root matches the current state root. This prevents the creation of invalid sessions that could reuse a chain of overlays that were previously committed or or a chain that is no longer valid because another overlay chain has been committed.
gab8i
force-pushed
the
gm_ensure_session_validity
branch
from
f4eb962 to
11d1764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When beginning a session, ensure that the oldest overlay’s previous root matches the current state root. This prevents the creation of invalid sessions that could reuse a chain of overlays that were previously committed or or a chain that is no longer valid because another overlay chain has been committed.