Skip to content

Update for Rails 5: no "Listing" on index#4

Open
southwolf wants to merge 3 commits intothrivesmart:masterfrom
southwolf:master
Open

Update for Rails 5: no "Listing" on index#4
southwolf wants to merge 3 commits intothrivesmart:masterfrom
southwolf:master

Conversation

@southwolf
Copy link
Copy Markdown
Contributor

No description provided.

@moorage
Copy link
Copy Markdown
Member

moorage commented Apr 9, 2016

Thanks! is this backwards compatible with rails 4?

@southwolf
Copy link
Copy Markdown
Contributor Author

@moorage I've updated the code to remain back compatibility for Rails 4 and fix #3. It requires loading your current Rails when running bootscaf. I haven't figure out how to load different versions of Rails in gemspec, so CI will fail (temporarily).

@moorage
Copy link
Copy Markdown
Member

moorage commented Apr 11, 2016

What do you mean "temporarily"?

Did you try spec.add_dependency "rails" ? Did that fail?

@southwolf
Copy link
Copy Markdown
Contributor Author

@moorage The purpose of this pull request is to load and test your "current" version of Rails, but spec.add_dependency "rails" without version number in CI will only get the latest rails (4.2.6 for now, and 5.0 in future). CI will pass, but that's not what I want, and not what I mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants