Skip to content

Update es.json#7

Open
manoletux wants to merge 2 commits intothrivedesk:masterfrom
manoletux:patch-1
Open

Update es.json#7
manoletux wants to merge 2 commits intothrivedesk:masterfrom
manoletux:patch-1

Conversation

@manoletux
Copy link
Copy Markdown

@manoletux manoletux commented Feb 3, 2026

Mejora de traducciones de varias palabras.

Summary by CodeRabbit

  • Documentation
    • Improved Spanish translations across the app: "Mis Conversaciones" (previously "Mina"), "Borradores" (was "Fabricación"), "Papelera" (was "Basura"), "Clave de token" (was "Tecla Token"), and a corrected "Canjear" for redemption text. These changes make labels and messages clearer and more consistent for Spanish-speaking users.

Mejora de traducciones de varias palabras.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 3, 2026

Walkthrough

Five Spanish localization strings in es-ES/es.json were updated: "mine", "draft", "trash", "token-key", and one "redeem" entry. Changes are textual only; there are no functional or API signature modifications.

Changes

Cohort / File(s) Summary
Spanish Localization
es-ES/es.json
Replaced 5 translation entries: "mine" → "Mis Conversaciones", "draft" → "Borradores", "trash" → "Papelera", "token-key" → "Clave de token", and one "redeem" → "Canjear". Text-only update; no code/logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Poem

🔧 Strings tightened, Spanish now sings clear,

"Borradores" in place, "Papelera" appears near,
Five small edits, no runtime fear,
Ship it fast, no fluff, just steer.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update es.json' is vague and generic, failing to convey the substantive nature of the translation improvements being made. Replace with a more descriptive title like 'Improve Spanish translations for clarity' or 'Fix Spanish translation strings in es.json' to better communicate the actual changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@es-ES/es.json`:
- Around line 36-41: Replace the value for the "mine" key in es.json: change
"Mis Mensajes" to "Mis conversaciones" (use sentence case — only the first word
capitalized) so the label correctly reflects conversations/tickets and matches
the file's casing style; update the "mine" entry accordingly.
- Line 108: Update the Spanish translation value for the key "token-key" in
es.json: replace the current value "Clave Token" with the grammatically correct
phrase "Clave del token" so the localization uses the proper Spanish possessive
construction; modify the string value associated with "token-key" (not the key
name itself) to "Clave del token".

es-ES/es.json Outdated
Comment on lines +36 to +41
"mine": "Mis Mensajes",
"unassigned": "Sin asignar",
"draft": "Fabricación",
"draft": "Borradores",
"assigned": "Asignado",
"closed": "Cerrado",
"trash": "Basura",
"trash": "Papelera",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# Read the file around the specified lines to see context and capitalization pattern
sed -n '30,50p' es-ES/es.json

Repository: thrivedesk/locales

Length of output: 971


🏁 Script executed:

# Also check if there are similar status/filter labels elsewhere in the file
rg -n '"mine"|"draft"|"trash"|"unassigned"|"assigned"|"closed"' es-ES/es.json -A 1

Repository: thrivedesk/locales

Length of output: 292


🏁 Script executed:

# Search the codebase for context on what "mine" represents (might be messages, tickets, etc.)
rg -i 'mine.*message|mine.*conversation|mine.*ticket' --type js --type ts --type vue -B 2 -A 2 | head -50

Repository: thrivedesk/locales

Length of output: 89


"Mis Mensajes" is broken — use "Mis conversaciones" instead.

Look, you've got a capitalization mess here. "Mis Mensajes" is Title Case while "Sin asignar" is sentence case. Pick one and stick with it. Also, "Mensajes" is too narrow for what this filter actually does — it's for conversations/tickets, not just messages. In a support system, you need clarity, not linguistic narrowness. Fix it now.

The fix
-  "mine": "Mis Mensajes",
+  "mine": "Mis conversaciones",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"mine": "Mis Mensajes",
"unassigned": "Sin asignar",
"draft": "Fabricación",
"draft": "Borradores",
"assigned": "Asignado",
"closed": "Cerrado",
"trash": "Basura",
"trash": "Papelera",
"mine": "Mis conversaciones",
"unassigned": "Sin asignar",
"draft": "Borradores",
"assigned": "Asignado",
"closed": "Cerrado",
"trash": "Papelera",
🤖 Prompt for AI Agents
In `@es-ES/es.json` around lines 36 - 41, Replace the value for the "mine" key in
es.json: change "Mis Mensajes" to "Mis conversaciones" (use sentence case — only
the first word capitalized) so the label correctly reflects
conversations/tickets and matches the file's casing style; update the "mine"
entry accordingly.

es-ES/es.json Outdated
"and-connect-your-edd-plugin": "y conecte su complemento EDD con ThriveDesk.",
"your-store-url": "La url de su tienda",
"token-key": "Tecla Token",
"token-key": "Clave Token",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

find . -name "es.json" -path "*/es-ES/*"

Repository: thrivedesk/locales

Length of output: 77


🌐 Web query:

Spanish grammar "clave del token" vs "clave token" translation

💡 Result:

“Clave del token” y “clave token” significan cosas parecidas, pero no suenan igual de naturales/precisas en español.

  • clave del token = la clave que pertenece a ese token (concreto). Es la opción más clara y estándar para expresar posesión/relación (“A de B”). La RAE describe estas construcciones también como apositivas con de (p. ej., “el problema del tráfico”). [1]
  • clave de token = clave asociada a tokens en general (más genérico, tipo categoría: “claves de token”). En documentación técnica se ve mucho esta pauta (por ejemplo, “clave de token”). [2]
  • clave token = calco del inglés (token key) usando aposición yuxtapuesta (“A B”). La RAE reconoce la aposición especificativa del tipo “A B” (dos nombres seguidos) como estructura posible en español, pero en registro técnico puede sonar más “jerga” o menos cuidada que “clave del/de token”. [1][3]

Recomendación práctica (traducción):

  • Si en inglés es “the token key” (token específico): “la clave del token”.
  • Si es un concepto general (“token key” como tipo de clave): “clave de token”.
  • Evita “clave token” salvo que estés copiando terminología interna/UX muy breve (etiquetas, columnas, etc.).

Fuentes: RAE sobre aposición (incluida la variante con de) [1]; uso técnico de “clave de token” [2]; ejemplo de uso de “clave token” en contexto divulgativo [3].


🏁 Script executed:

sed -n '105,111p' ./es-ES/es.json

Repository: thrivedesk/locales

Length of output: 401


Fix Spanish grammar for "token-key" — "Clave Token" is an English calque that needs proper Spanish structure.

Use "Clave del token" instead. The RAE recognizes that Spanish possessive constructions require a preposition (specifically "de" or "del"), and this produces the natural, formal phrasing your localization needs.

🛠️ Proposed fix
-  "token-key": "Clave Token",
+  "token-key": "Clave del token",
🤖 Prompt for AI Agents
In `@es-ES/es.json` at line 108, Update the Spanish translation value for the key
"token-key" in es.json: replace the current value "Clave Token" with the
grammatically correct phrase "Clave del token" so the localization uses the
proper Spanish possessive construction; modify the string value associated with
"token-key" (not the key name itself) to "Clave del token".

Copy link
Copy Markdown
Author

@manoletux manoletux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REviewed suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant