SCAL-290216-1 add local-network-access to iframe allow attribute

[shivam-kumar-ts]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @shivam-kumar-ts, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the TsEmbed component to include local-network-access in the allow attribute for iframes. This modification is crucial for embedded applications that require interaction with local network resources, ensuring that iframes can function correctly in such environments while maintaining appropriate security controls.

Highlights

• iframe Permissions: The local-network-access permission has been added to the allow attribute of iframes. This change enables embedded content to access resources on the local network, expanding the capabilities of the TsEmbed component.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mnk-blr]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@417

commit: 7576769

[gemini-code-assist]

Code Review

This pull request introduces the local-network-access permission to the iframe's allow attribute. This change enables embedded content to access the user's local network, posing a security risk related to Internal SSRF. It is strongly recommended to make this permission opt-in via a configuration flag to adhere to the principle of least privilege and enhance overall security.

[gemini-code-assist]

The addition of local-network-access to the iframe allow attribute enables embedded content to access the user's local network (Private Network Access). This creates a security risk, potentially allowing Internal Server-Side Request Forgery (SSRF) attacks if the embedded site is compromised. To mitigate this, it is crucial to make this permission opt-in. Consider implementing a new boolean flag, such as allowLocalNetworkAccess in EmbedConfig, to dynamically control the allow attribute, ensuring this permission is only granted when explicitly required.

Suggested change

	iFrame.allow = 'clipboard-read; clipboard-write; fullscreen; local-network-access;';
	iFrame.allow = "clipboard-read; clipboard-write; fullscreen;" + (this.embedConfig.allowLocalNetworkAccess ? " local-network-access;" : "");

[sonar-prod-ts]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication