Skip to content

SCAL-183953 Wrong Error Msg #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yinstardev wants to merge 4 commits into
base: main
Choose a base branch
from
Open

SCAL-183953 Wrong Error Msg #9

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce04f77
SCAL-183953 Wrong Error Msg
yinstardev Apr 15, 2024
9927441
SCAL-183953 Wrong Error Msg
yinstardev Apr 15, 2024
0a99a64
SCAL-183953 Test Case Failure
yinstardev Apr 15, 2024
e628076
SCAL-183953 Test Case Failure
yinstardev Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,18 @@ export function rise(
let payload;
try {
const contentType = response.headers.get('Content-Type');
const isJsonContent = contentType && contentType.includes('application/json');
const isTextContent = contentType && contentType.includes('text');
if (isTextContent) {
if (isJsonContent) {
try {
payload = await response.json();
} catch (jsonError) {
payload = { [errorroot]: { message: 'Received unparsable JSON response from the server.' } };
}
} else if (isTextContent) {
payload = { [errorroot]: { message: await response.text() } };
} else {
payload = await response.json();
payload = { [errorroot]: { message: 'Unsupported content type in server response.' } };
}
} catch (e) {
throw new options.ErrorClass(response.statusText, response.status, e);
Expand Down