Fix flag for getDSSuggestions

[shikharbsar]

No description provided.

[mnk-blr]

⛔ Snyk checks have failed. 5 issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (5)
⛔	Open Source Security	0	3	2	0	5 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Summary of Changes

Hello @shikharbsar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the enableSpotterDataSourceDiscovery flag was being incorrectly retrieved due to a misplaced property. The changes ensure that the flag is accessed from its proper nested location within the configuration object and that its value is robustly interpreted, accounting for potential string representations. This fix enhances the reliability of the data source discovery feature by ensuring its availability is determined accurately.

Highlights

• Flag Access Correction: The enableSpotterDataSourceDiscovery flag is now correctly accessed from info.configInfo instead of directly from the info object, resolving an incorrect property path.
• Robust Flag Interpretation: The isDatasourceDiscoveryAvailable method has been enhanced to correctly interpret the enableSpotterDataSourceDiscovery flag, handling both boolean true and string "true" values, and includes a null check for sessionInfo.
• Test Alignment: All relevant test files have been updated to reflect the new nested structure of the enableSpotterDataSourceDiscovery flag within mock sessionInfo objects, ensuring test accuracy.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a bug in how the enableSpotterDataSourceDiscovery flag is handled. The changes correctly source the flag from configInfo, improve the validation logic to handle both boolean and string values, and add a necessary check for sessionInfo initialization. The test files have also been updated accordingly to reflect these changes. I've provided one suggestion to make the flag checking logic more concise.