Support running examples by visual selection #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified the public function
RunNearestSpec()to support visual selections. It behaves the same as before in Normal mode, but now runs, e.g.,$ rspec <spec_file>:8:9:10:11:12for a visual selection spanning lines 8–12.I also changed the name to
RunExamples()because it seemed semantically more correct to me, but kept the old one in the interest of backwards compatibility.I did not, however, run the tests or add a test for this new function. I'd be happy to, but I'd like to make sure that the maintainers are interested in pulling this change before committing to all that work.