Reset stubs for class methods and attributes #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a number of stubs for class attributes that were bleeding between different examples and causing flakiness. I added a before each blog in spec_helper.rb that will reset all the different things that caused this flakiness including: - Terrapin::CommandLine.path - Terrapin::CommandLine.runner
garciadanny
reviewed
Jul 9, 2025
| after do | ||
| FileUtils.rm_f("#{Terrapin::CommandLine.path}/ls") | ||
| end | ||
|
|
There was a problem hiding this comment.
Thanks for moving the setup stuff within the specific test that needs it!
garciadanny
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throughout the examples were stubs for class attributes that were bleeding between different examples and causing flakiness.
I added a before each block in spec_helper.rb that will reset the different things that caused this flakiness including:
Moved the before and after blocks from runners_spec into the only example they apply to, since there could be conflicts between the befores.
I tested this locally with Ruby 3.4.4, 3.3.7, 3.2.7, 3.1.7, and 2.7.8