Skip to content

Conversation

@stevepolitodesign
Copy link
Contributor

Alternative to #1261, lifted from the existing generator. However, since the authoring of that generator, the structure of config/environments/test.rb has changed, so we no longer need conditionals.

Additionally, we set action_dispatch.show_exceptions to :none rather than comment it out to be explicit about the value.

Alternative to #1261, lifted from the existing [generator][]. However,
since the authoring of that generator, the structure of
`config/environments/test.rb` has changed, so we no longer need
conditionals.

Additionally, we set `action_dispatch.show_exceptions` to `:none` rather
than comment it out to be explicit about the value.

[generator]: https://github.com/thoughtbot/suspenders/blob/main/lib/generators/suspenders/environments/test_generator.rb

Co-authored-by: Rob Whittaker <rob@thoughtbot.com>
Co-authored-by: Jose Blanco <53355525+laicuRoot@users.noreply.github.com>
@stevepolitodesign stevepolitodesign merged commit a057bd6 into sp-cli Dec 12, 2025
2 checks passed
@stevepolitodesign stevepolitodesign deleted the sp-cli-test-env branch December 12, 2025 20:53
stevepolitodesign added a commit that referenced this pull request Dec 19, 2025
Alternative to #1261, lifted from the existing [generator][]. However,
since the authoring of that generator, the structure of
`config/environments/test.rb` has changed, so we no longer need
conditionals.

Additionally, we set `action_dispatch.show_exceptions` to `:none` rather
than comment it out to be explicit about the value.

[generator]: https://github.com/thoughtbot/suspenders/blob/main/lib/generators/suspenders/environments/test_generator.rb

Co-authored-by: Rob Whittaker <rob@thoughtbot.com>
Co-authored-by: Jose Blanco <53355525+laicuRoot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants