Potential introduction of actions #1263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the last rewrite, we generate a new gem and do a directory swap, while making sure to preserve important files like NEWS.md. This branch will serve as a new base for us to merge into while we build up an [application template][template]. This approach is largely inspired by [staples][]. [template]: https://guides.rubyonrails.org/generators.html#application-templates [staples]: https://github.com/stevepolitodesign/staples
Introduces [Procfile][1] to automatically start the server and run migrations during the [release phase][2]. Additionally, we update our [database connection preference][3] to account for [nuance in connecting with Heroku][4]. [1]: https://devcenter.heroku.com/articles/getting-started-with-rails8#create-a-procfile [2]: https://devcenter.heroku.com/articles/release-phase [3]: https://guides.rubyonrails.org/configuring.html#connection-preference [4]: https://discuss.rubyonrails.org/t/brainstorming-approaches-to-reconcile-rails-8s-default-multi-db-setup-with-database-url/86769
purinkle
commented
Dec 11, 2025
Comment on lines
28
to
40
| private | ||
|
|
||
| def options | ||
| {} | ||
| end | ||
|
|
||
| def relative_to_original_destination_root(path, remove_dot = true) | ||
| path | ||
| end | ||
|
|
||
| def say_status(...) | ||
| # Silence output | ||
| end |
Contributor
Author
There was a problem hiding this comment.
We have to add all these methods to get uncomment_lines to work. The other option is to do a gsub instead of using Thor. Both have pros and cons.
Contributor
There was a problem hiding this comment.
Is the idea that this class would be invoked from the application template?
Maybe something like?
If so, I worry it adds a lot of overheard, when we could just call the following directly in the application template like you're doing in #1261
uncomment_lines(
"config/environments/test.rb",
/config\.i18n\.raise_on_missing_translations\s*=\s*true/
)
comment_lines(
"config/environments/test.rb",
/config\.action_dispatch\.show_exceptions\s=\s:rescuable/
)But, it's possible I'm misunderstanding.
spec/suspenders/actions/environments/test/raise_on_missing_translations_spec.rb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.