Skip to content

Conversation

@JeffySam
Copy link

@JeffySam JeffySam commented Jan 30, 2026

Description

This PR migrates the units/index parent state from AngularJS to Angular and removes the legacy CoffeeScript implementation.

The Angular version preserves the existing behaviour of the parent state, including unit loading, role resolution, global view setup, and routing. No functional changes are intended as part of this migration.

This change establishes a clean Angular parent state for all units/* child routes and removes the remaining AngularJS entry points for the units index state.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [✓] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The changes were tested locally to ensure the Angular parent state behaves equivalently to the legacy implementation.

Testing performed:

  • Navigated to /units/:unitId using valid and invalid unit IDs
  • Verified unit and unit role resolution for different user roles
  • Navigated to existing unit child routes to ensure shared context is preserved
  • Refreshed pages on unit routes to confirm routing stability
  • Confirmed no console or routing errors are present

Testing Checklist:

  • [✓] Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • [✓] My code follows the style guidelines of this project
  • [✓] I have performed a self-review of my own code
  • [✓] I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [✓] My changes generate no new warnings
  • [✓] I have requested a review from @macite and @jakerenzella on the Pull Request

Author: Jeffy Sam

Copy link

@rammakablecode rammakablecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm ci and npm build passed when I tested, Child components required to complete migration.. so far all good on the partial migration

@kacieje
Copy link

kacieje commented Jan 31, 2026

Hi Jeffy,
I wasn't able to get this code to run, rails returns the following routing error.

unknown,FATAL: \nActionController::RoutingError (No route matches [GET] "/api/auth/signout_url"):\n

I'm not entirely sure which part of the change is responsible but I don't have this error switching back to 9.x.

@JeffySam
Copy link
Author

Hi @kacieje Thanks for checking. Yes — this work is intended to run against 9.x.

@kacieje
Copy link

kacieje commented Feb 1, 2026

Hi Jeffy - to be clear, your changes don't run correctly, rails fails. This does not happen with the current 9.x branch, only with the code from your PR.

@JeffySam
Copy link
Author

JeffySam commented Feb 1, 2026

@kacieje so how can i make it running? can i please get some help..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants