-
Notifications
You must be signed in to change notification settings - Fork 72
docs: add Units module migration investigation and plan #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: add Units module migration investigation and plan #166
Conversation
✅ Deploy Preview for thoth-tech ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SteveDala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The plan to migrate the units module seems cogent and well thought through. Although I'm sure more challenges will arise as a result of the attempt to migrate this module, this represents a good starting point to do so.
|
Hi @JeffySam, in your development environment, please execute Checking formatting...
[warn] src/content/docs/Products/OnTrack/Documentation/Front End Migration/Migration/UNITS_MODULE_MIGRATION_INVESTIGATION.md
[warn] src/content/docs/Products/OnTrack/Documentation/Front End Migration/Migration/UNITS_MODULE_MIGRATION_PLAN.md
[warn] Code style issues found in 2 files. Run Prettier with --write to fix.
Error: Process completed with exit code 1. |
|
hi @SteveDala i did execute npm run format like u said |
|
@JeffySam please make sure your changes are based on the latest upstream changes to main. |
Description
This pull request adds documentation describing the current state and planned approach for migrating the Units module from AngularJS (CoffeeScript) to Angular (TypeScript).
The documentation focuses on the migration of the Units state hierarchy, including the legacy state aggregator (
units/states/states.coffee) and its Angular replacement. It captures the current migration status, identifies remaining AngularJS states, and outlines a parent-first migration strategy to safely unblock downstream work.Two documents are included:
This PR is documentation-only and does not modify application code.
Fixes: N/A
Type of change
How Has This Been Tested?
No runtime or build testing was required, as this PR contains documentation only.
Testing Checklist
npm run format(not applicable — no code changes)npm run build(not applicable — no code changes)npm run devand/ornpm run preview, using:Checklist