Skip to content

Conversation

@31Husain31
Copy link
Contributor

Hello to all,

This documentation is related to Front End Migration.

I've completed the investigation for the task-dashboard migration and documented my findings along with a proposed approach for completing the migration.

This PR adds two documentation files to the Front End Migration folder:

  1. task-dashboard-investigation.md - Documents the current state of the task-dashboard migration, what's already been done, and what still needs to be completed.

  2. task-dashboard-pr-plan.md - Breaks down the remaining work into 5 smaller PRs to make the migration easier to review and merge.

Key findings from the investigation:

  • Most of the migration work is already done by a previous developer
  • The Angular components are working fine (already used in inbox)
  • Main remaining work is cleanup - updating templates, removing old files, and updating documentation

The PR plan outlines a low-risk approach to finish this migration with small, testable changes.

Looking forward to feedback!

Thanks,
Husain


Name: Husainuddin Mohammed
ID: 223380186

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for thoth-tech ready!

Name Link
🔨 Latest commit fd2c638
🔍 Latest deploy log https://app.netlify.com/projects/thoth-tech/deploys/697eab8d9eeab60008f46361
😎 Deploy Preview https://deploy-preview-162--thoth-tech.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

YG-GOV
YG-GOV previously requested changes Jan 24, 2026
Copy link
Contributor

@YG-GOV YG-GOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this ,the investigation and PR plan are clear and easy to follow, and breaking the remaining work into smaller PRs makes a lot of sense. The summary of what’s already been done vs what’s left is especially helpful for anyone jumping into the migration. I did notice the Netlify checks are currently failing, so might be worth taking a quick look at the deploy logs before merge

@31Husain31
Copy link
Contributor Author

Hi @YG-GOV, I've fixed the Netlify deployment issues for this PR as well. The frontmatter has been added to the task-dashboard files, and the inbox files have been removed as I realised I mistakenly added extra 2 files (they're in PR #163). All checks are now passing. I believe its safe to merge now.

Copy link

@Rana7xi Rana7xi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really helpful context for the dashboard migration. The docs give a clear picture of where things stand and save a lot of time trying to figure out what’s already been migrated and what hasn’t. The step-by-step PR breakdown makes the remaining work feel much more manageable.

One small improvement that could help future readers is adding cross-links between the investigation notes and the PR plan, so it’s easy to jump between the two.

Overall, this is a good reference point for continuing the migration and will be useful for anyone picking this up later.

@rammakablecode
Copy link

rammakablecode commented Jan 26, 2026

re-reviewed changes below

Copy link

@rammakablecode rammakablecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed this PR scoped to the task-dashboard migration investigation and #163 documenting the migration plan

Can confirm the changes

  • Unintentionally added files (inbox files) have been removed, and adding the frontmatter to task-dashboard

The documentation clearly captures the current state of the task-dashboard migration and provides useful context for future

@BrianDangDev
Copy link
Contributor

Failed check and the plan is lengthy and not efficient, why would you need 5 separate PR for this componenet? The purpose of the plan is for the next cohort to know which child components to work on first. I don’t see any thought process or effort in this plan it seems to come straight from AI

@31Husain31
Copy link
Contributor Author

Hi @BrianDangDev,
Thanks for the feedback. You're right - the original 5 PR split didn't make sense.
I've revised it to 2 PRs instead of 5. After analysing the code dependencies, I realized the template update, state registration, and file cleanup need to happen together as one atomic change. Splitting them creates broken intermediate states.
What I updated:

Consolidated PR plan with technical reasoning for why changes must be together
Named all 7 child components and their purposes
Added dependency diagrams showing migration flow
Included practical guidance and time estimates for next cohort

The revised docs should now show actual thought process rather than a generic task list.

In regards to the failed check, I am not sure why that happened as for me it indicates that all checks are successful.
image

Let me know if there's any questions.

@BrianDangDev
Copy link
Contributor

Hi @31Husain31 please check the ci/cd error

@31Husain31
Copy link
Contributor Author

Hi @31Husain31 please check the ci/cd error

I believe this should work now. I was told that CI/CD error was occurring due to no blank line at the end of document. I made the changes.

Copy link
Collaborator

@SteveDala SteveDala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a sensible plan for the migration of the task-dashboard component. Ideally a task has already been created for this work and the pages of this investigation added to it once they go live.

@SteveDala SteveDala dismissed YG-GOV’s stale review February 1, 2026 01:32

YG-GOV's requested change was only in regards to the Netlify checks, which are now passing.

@SteveDala SteveDala merged commit 85a5729 into thoth-tech:main Feb 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants