-
Notifications
You must be signed in to change notification settings - Fork 19
Car-Race-Game Tutorial #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KhushiLaddi08
wants to merge
8
commits into
thoth-tech:main
Choose a base branch
from
KhushiLaddi08:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
omckeon
requested changes
May 15, 2024
Contributor
omckeon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all:
- Update the alt text for any images to properly explain what the image is showing.
For Step 1:
- Remove the "Environment Setup" section (not needed and includes mostly outdated information).
- It would be better to create a file tree diagram rather than the images, as these images are somewhat confusing.
Step 2:
- Some of the wording in the functions section is confusing (not sure if all of the dot points are relevant).
- Code indentation still needs to be fixed.
- What is the purpose of Step 2? Is it just to give information? (As is only covering cherry picked parts of the code it seems)
- What is the flowchart showing? (I can't see any relevant information here?)
- Step 2 seems better as a bit of an appendix rather than being part of the main tutorial guide.
Step 3:
- Mostly the same feedback as part 3 - these 2 steps should just be in appendix pages at the end.
- Flowchart also not adding anything to this either.
Step 4:
- This looks like a better place for the tutorial to start (with maybe a bit at the start for the program.cpp initial code like the game loop). And add the file setup mentioned for step 1 into the top of this step as well.
- Check the order of the information in this step so that you are starting with the struct and enum info, and then the functionality after.
- Also, I would suggest renaming this to something more like "Car Functionality" or similar.
- Flowchart can be removed as it doesn't add anything and is confusing.
- Add a "Final Car Code" section at the end with the entire "car.h" code, "car.cpp" code and "program.cpp" code (the file with the main function) in code blocks (1 for each).
- More context would be needed for an actual tutorial, but this looks to be more like a tutorial proposal, so just focus on updating the general outline/format.
- And move this folder into Tutorial proposals rather than Tutorials.
Step 5:
- The first part is called Game Initialisation, but is actually showing code for drawing the game? These are not the same thing. Initialisation is where you would create the variables in main...
- Missing the game_data struct information as well.
- And then mostly same feedback as Step 4.
Step 6:
- This is more of an appendix "How to Play" page.
- Update the file name to something more relevant.
- Remove the flowchart.
Step 7:
- Remove the flowchart.
- This is definitely just "Tutorial Proposal" style, as the format would need updating to read like a proper tutorial, but it seems to include all the information for someone else to use in a future trimester, so just add a "Final Code" section at the end with the entire code for all the different files in their own code block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to describe the car race game I build before with some new updates.
Contents
Additional Notes
This pull request basically focuses on brief information and list of changes asked.