Allow duplicate morphology names #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorstenhater
requested changes
Mar 9, 2023
| .ok_or_else(|| nml2_error!("Morph has no id"))?; | ||
| let cell = node | ||
| .parent() | ||
| .ok_or(nml2_error!("Morphology has no parent"))?; |
Owner
There was a problem hiding this comment.
I think that's incorrect. You can have this
<morphology id="m1">
...
</morphology>
<cell id="c1">
<morphology id="m1" />
</cell>
<cell id="c0">
<morphology id="m1" />
</cell>
Owner
There was a problem hiding this comment.
Thus you need to duplicate morphologies under mrf, allow references in mrf, or rename ids. Your choice ;)
Collaborator
Author
There was a problem hiding this comment.
Horrible. Thanks for spotting... maybe default to a name like 'toplevel_m1' for these?
Owner
There was a problem hiding this comment.
I think the Arbor internal NML2 reader calls them cell morphologies and just plain morphologies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the CA1 example, we have multiple cells with id="morphology". Currently these all get overwritten and we end up with a single morphology.nml file. This PR fixes that.