Open
Conversation
iharthi
force-pushed
the
web-eid-2024-12-retry-on-network-error
branch
from
933536c to
fe14bfb
Compare
Jyrno42
force-pushed
the
web-eid-2024-12-retry-on-network-error
branch
from
fe14bfb to
33375df
Compare
Jyrno42
reviewed
Apr 10, 2025
IdentificationManager.js
Outdated
|
|
||
| try { | ||
| const response = await fetch(url, { method, headers, body }); | ||
| if (`${response.status}` !== "410") { |
Contributor
There was a problem hiding this comment.
nitpick but maybe doing it the other way around and using an early return for 410 would be easier to read.
iharthi
force-pushed
the
web-eid-2024-12-retry-on-network-error
branch
from
33375df to
b6aed7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases when running on a mobile device, the browser going into background and back may result in network error when polling signing status.
This MR (done on top of !14) adds a retry logic that tries to re-do the query on network error before giving up. BE changes are needed to take full advantage of this (see thorgate/django-esteid#72)