Fix Arithmetic lossless scans truncating with DNL markers.#102
Open
robert-ancell wants to merge 1 commit intothorfdbg:masterfrom
Open
Fix Arithmetic lossless scans truncating with DNL markers.#102robert-ancell wants to merge 1 commit intothorfdbg:masterfrom
robert-ancell wants to merge 1 commit intothorfdbg:masterfrom
Conversation
If a scan runs out of arithmetic bits and we are on the start of a line the decoder stops decoding even though the rest of the line may still be valid, just not require any bits. Instead, when we receive the DNL update the image height and continue processing as normal.
Contributor
Author
Contributor
Author
|
I'm not 100% sure I have the logic correct, it's not clear to me if we still need a case where ParseMCU is not called. |
Owner
|
Hi Robert, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


If a scan runs out of arithmetic bits and we are on the start of a line the decoder stops decoding even though the rest of the line may still be valid, just not require any bits.
Instead, when we receive the DNL update the image height and continue processing as normal.