Skip to content

Fix normalize-send when sending object data, add test #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
viggyfresh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix normalize-send when sending object data, add test #286

viggyfresh wants to merge 2 commits into from

Conversation

@viggyfresh
Copy link

@viggyfresh viggyfresh commented Nov 8, 2019

  • This should close Socket.IO Emit args serialized to string #245
  • However...I am not sure if this is actually desired behavior for non-socketIO clients - but I'm pretty sure the native browser WebSocket spec only supports sending stringified messages, so this is probably OK to merge

@gCardinal gCardinal mentioned this pull request Apr 3, 2020
Open
@sunsheeppoplar
Copy link

sunsheeppoplar commented Sep 17, 2020

Thanks for putting this pull up, @viggyfresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Socket.IO Emit args serialized to string

2 participants

@viggyfresh @sunsheeppoplar