Fix #216: Implement robust JSON serialization for user settings#228
Merged
thomwiggers merged 1 commit intodevelopfrom Feb 18, 2026
Merged
Fix #216: Implement robust JSON serialization for user settings#228thomwiggers merged 1 commit intodevelopfrom
thomwiggers merged 1 commit intodevelopfrom
Conversation
|
🤖 Hi @thomwiggers, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @thomwiggers, but I was unable to process your request. Please see the logs for more details. |
- Implement JSON-based serialization for complex data types in Users plugin - Update ACL plugin to use JSON for superadmin and permissions management - Add deserialize_setting helper for robust decoding across the bot - Update tests to reflect JSON storage format
thomwiggers
force-pushed
the
fix/issue-216-redis-serialization
branch
from
f2fcfad to
d39ee9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #216.
This PR implements a robust JSON-based serialization strategy for user settings and permissions, ensuring compatibility with database backends that only support string values (e.g., Redis).
Changes:
onebot.plugins.users:jsonfor serializing all non-string types (lists, dicts, booleans, etc.).deserialize_settinghelper (and extended bot method) for safe JSON decoding.onebot.plugins.acl:superadminand permission management.tests/test_plugin_acl.pyto align with the JSON storage format.