Merged
Conversation
thomas-gale
approved these changes
Feb 3, 2025
Owner
thomas-gale
left a comment
thomas-gale
left a comment
There was a problem hiding this comment.
Awesome.
I think we can update the camera's arcball impl to possibly use the same rotmat code (I'll need to double check if this makes sense).
Owner
|
Ok, I realise that your comment on overlap means a couple of mergey things to resolve, I'll take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we can position objects but we can't orient them.
This adds the ability to add orientation components and gets the raytracer to respect them.
We update the scene to rotate the boxes around the y axis to look pretty.
There is some overlap in functionality added for the other 2 PRs added.